Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(issue forms): port feature-request to form structure #7253

Merged
merged 3 commits into from
May 4, 2021
Merged

chore(issue forms): port feature-request to form structure #7253

merged 3 commits into from
May 4, 2021

Conversation

siegerts
Copy link
Contributor

@siegerts siegerts commented May 4, 2021 •
edited
Loading

Description of changes

  • chore(feature-request): replace md template with new form
  • chore(issue form): clean up intro md section

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siegerts siegerts requested a review from a team as a code owner May 4, 2021 18:04
@siegerts siegerts requested review from attilah and renebrandel May 4, 2021 18:21
@codecov-commenter
Copy link

Codecov Report

Merging #7253 (6277f73) into master (8775152) will decrease coverage by 4.15%.
The diff coverage is 45.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7253      +/-   ##
==========================================
- Coverage   56.43%   52.27%   -4.16%     
==========================================
  Files         445      491      +46     
  Lines       21859    25248    +3389     
  Branches     4373     4952     +579     
==========================================
+ Hits        12336    13199     +863     
- Misses       8745    11097    +2352     
- Partials      778      952     +174
Impacted Files Coverage Δ
...ls/awscloudformation/utils/synthesize-resources.ts 16.00% <ø> (ø)
packages/amplify-cli-core/src/deploymentState.ts 100.00% <ø> (ø)
...amplify-cli-core/src/feature-flags/featureFlags.ts 83.10% <ø> (ø)
...-cli/src/extensions/amplify-helpers/git-manager.ts 85.18% <ø> (ø)
.../amplify-frontend-ios/lib/amplify-config-helper.js 1.01% <ø> (ø)
...provider-awscloudformation/src/aws-utils/aws-s3.ts 9.32% <0.00%> (-0.77%) ⬇️
...ion/src/iterative-deployment/deployment-manager.ts 7.05% <0.00%> (ø)
...y-provider-awscloudformation/src/resourceParams.js 15.15% <ø> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...der-awscloudformation/src/configuration-manager.ts 5.55% <3.70%> (+0.18%) ⬆️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b9569...6277f73. Read the comment docs.

@cjihrig cjihrig merged commit 15b4eda into aws-amplify:master May 4, 2021
cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
@siegerts @cjihrig-aws
chore(issue forms): port feature-request to form structure (aws-ampli…
7d47397 
…fy#7253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@attilah attilah Awaiting requested review from attilah

@renebrandel renebrandel Awaiting requested review from renebrandel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siegerts @codecov-commenter @cjihrig